Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Converter.py] fix NameError in last commit #3936

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

Huevos
Copy link
Contributor

@Huevos Huevos commented Mar 31, 2024

No description provided.

@WanWizard
Copy link
Member

What exactly is being fixed here? It looks more like conversion to a oneliner?

@Huevos
Copy link
Contributor Author

Huevos commented Mar 31, 2024

Previous:

	def appendToStringWithSeparator(self, str, part):
		if str == "":
			str = part
		else:
			text = f"{text}{self.separatorChar or ' '}{part}"
		return text

With this commit:

	def appendToStringWithSeparator(self, text, part):
		return f"{text}{self.separator or ' '}{part}" if text else part

There are 2 NameErrors.

str -> text
self.separatorChar -> self.separator

@WanWizard WanWizard merged commit ba386fe into OpenPLi:develop Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants