Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 'stream relay' service if need stop stream #3965

Merged
merged 1 commit into from Apr 28, 2024

Conversation

Dima73
Copy link
Contributor

@Dima73 Dima73 commented Apr 26, 2024

No description provided.

@littlesat
Copy link
Member

Sorry again I do not understand why this is needed.... please discuss this first on the forum before doing such merge requests here and/or better describe why it is needed, which issue it does resolve etc....

@Dima73
Copy link
Contributor Author

Dima73 commented Apr 26, 2024

Sorry again I do not understand why this is needed.... please discuss this first on the forum before doing such merge requests here and/or better describe why it is needed, which issue it does resolve etc....

[Navigation] getClientsStreaming - filtering internal stream

Dont stop stream if this stream relay(for stop stream relay need stop service)

@littlesat
Copy link
Member

littlesat commented Apr 27, 2024

On that other commit I had some questions... Why hide it as it is still somehow streamed....?
Where did you get this idea from?
It would be helpful when you add more comments so I understand the need.... I need to guess why you're suggesting this (with good attentions of course). What is the problem and how/why/what did you try to target.

I prefer to show the stream as it is a stream (unless it is streamed locally), but indeed when you try to stop it, you can block it at the screen with the streams with a popup that gives a warning that it is a local stream which may break a 'streamrelay'....

@Dima73
Copy link
Contributor Author

Dima73 commented Apr 27, 2024

'stream relay' not really stream this local host.
For stop 'stream relay' need only stop service.
He should not be counted as one of the eStreamServer.getInstance().getConnectedClients().
Same as When box is shutting down do not show stream is busy for stream relay

@littlesat
Copy link
Member

Partly agree... but it is still a stream like any other...

@Dima73
Copy link
Contributor Author

Dima73 commented Apr 28, 2024

This stream can only be disabled by disabling the service.
We shouldn't count him on the eStreamServer.getInstance().getConnectedClients() list at all.

@littlesat
Copy link
Member

littlesat commented Apr 28, 2024

Not fully true. You can stop it... the overview of streams also indicate it is localhost. So somehow it is still up to the user and that is why I did decide not to stealth/hide this

@littlesat littlesat merged commit 7200947 into OpenPLi:develop Apr 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants