Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A/V settings] add option 'Audio volume step size' limit (1-10) #749

Closed
wants to merge 1 commit into from
Closed

Conversation

Dima73
Copy link
Contributor

@Dima73 Dima73 commented Feb 20, 2017

No description provided.

@littlesat
Copy link
Member

littlesat commented Feb 22, 2017

Why should you do this? i think this make no sense at all....
Why are you all "playing" with these volume settings and only reducing the possible steps....?

@persianpros
Copy link
Contributor

I guess with this we can set how much we want to increase or decrease the volume right ?

@Dima73
Copy link
Contributor Author

Dima73 commented Feb 22, 2017

Current step size is 5( 0-100).

@persianpros
Copy link
Contributor

persianpros commented Feb 22, 2017

It's really a good option in my opinion :)
And it's not reducing the possible steps but it will let you decide how much do you really need ;)

@Taykun345
Copy link

Taykun345 commented Feb 22, 2017 via email

@littlesat
Copy link
Member

littlesat commented Feb 23, 2017

Current step size is 5( 0-100).
->
I you sure I cannot find it in the code (sorry)

i know it are 20 steps.... but what actually defines the volume... (I remember we had 64???)

Sounds like we could consider to take a really good look at this... And it sounds like this is still something kept for years in enigma2 which was never correctly restructured and restreamelined...

@littlesat
Copy link
Member

Sorry I'm a bit lost here... in volume control I see +/- 1....

@littlesat
Copy link
Member

Actually there are 64 steps (0..63) Then they put it in a scale of 100 (0..100)... and then.... reduce this....
Looks like 3 steps of conversion... this is really "crasy"....

@littlesat
Copy link
Member

littlesat commented Feb 23, 2017

Now I found were the steps 5 are made....

Don't you thing we should go for 0..63 range instead of going from 0..100 first....? Actually these are the values we do currently set in real life... 63, 60, 57, 54, 50, 47, 44, 41, 38, 35, 32, 28, 25, 22, 19, 16, 13, 9, 6, 3, 0 (were 63 = 0% and 0 = 100%)

As far I see (based on code comments) this should indicate the "reducement in steps of 1dB from the full volume.

First I think we should do something about this wierdness.... And suggest to define it in dB and then make e.g. steps in 3dB less (what we approx. are doing down in different scales...)

I have no idea about the UI concequentes to change this to 63-0 instead of 0-100....

@littlesat
Copy link
Member

littlesat commented Feb 23, 2017

But then something else kicked in what requires 0..100..... :( The complete volume control is in between for 12 years made wierd....

@Dima73 Dima73 closed this Feb 25, 2017
@littlesat littlesat reopened this Feb 25, 2017
@littlesat
Copy link
Member

littlesat commented Feb 25, 2017

Why are you closing these and stop the discussion?

This DMM's patch looks equal....
http://git.opendreambox.org/?p=enigma2.git;a=commitdiff;h=477209fc58d324d75a62f87f0502ddd298c04161#patch28

@Dima73
Copy link
Contributor Author

Dima73 commented Feb 25, 2017

Yes, I took the example of the DMM.
This is the easiest option, openATV option is very difficult.

@littlesat
Copy link
Member

littlesat commented Feb 25, 2017

We have to copy it with care.... And I'm still thinking about it because the real steps go by 5.... I think when we make this we have to make it real.... Even more simple.... Set the step in cpp and make the steps there and move the step option from up down... And remove the default... I hope you understand what I mean... But again to make it really smart it might break some plugins, but Imdo not know any....

@littlesat
Copy link
Member

I just want to set a step size as config to that cpp stuff... ;)

@littlesat
Copy link
Member

FYI: 741785b

It was made wierd so I need make some stuff to keep it backwards compatible....

@littlesat littlesat closed this Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants