Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_opf_path function #270

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gangagyatso4364
Copy link

No description provided.

eroux
eroux previously approved these changes Jan 9, 2024
Copy link
Contributor

@eroux eroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaldan007
Copy link
Contributor

@eroux the https://github.com/OpenPecha/Toolkit/blob/master/tests/test_utils.py is suppose to test the download_pecha function which is suppose to return the full opf path(one with .opf) but it not happening hence we are facing issue. Isn't it better to fix from download_pecha

@eroux
Copy link
Contributor

eroux commented Jan 9, 2024

ah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Early Return in get_opf_path Method in OpenPechaGitRepo Class
3 participants