cups-browsed, driverless: Correct attributes of get-printer-attribute…

…s IPP request.
OpenPrinting · Feb 11, 2019 · 5259bb7 · 5259bb7
1 parent 6160b81
commit 5259bb7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/NEWS b/NEWS
@@ -3,6 +3,13 @@ NEWS - OpenPrinting CUPS Filters v1.22.0 - 2019-01-18
 
 CHANGES IN V1.22.1
 
+	- cups-browsed, driverless: When polling the printer's
+          capabilities via get-printer-attributes IPP request for
+          driverless printing, use the attributes "all" and
+          "media-col-database". Without "all" some printers do not
+          report "urf-supported" and without "media-col-database" not
+          all paper size and marging info gets reported (Issue #22,
+          Pull request #86, CUPS issue #5484).
 	- braille: Document how to rework output before
 	  embossing. Thanks to Samuel Thibault for this patch (Pull
 	  request #90).

diff --git a/utils/cups-browsed.c b/utils/cups-browsed.c
@@ -3846,9 +3846,7 @@ get_printer_attributes(const char* uri) {
   char valuebuffer[65536];
   static const char * const pattrs[] =
   {
-    "job-template",
-    "printer-defaults",
-    "printer-description",
+    "all",
     "media-col-database"
   };
   /* Request printer properties via IPP to generate a PPD file for the

diff --git a/utils/driverless.c b/utils/driverless.c
@@ -479,9 +479,7 @@ generate_ppd (const char *uri)
   int i, fd, bytes;
   static const char * const pattrs[] =
   {
-    "job-template",
-    "printer-defaults",
-    "printer-description",
+    "all",
     "media-col-database"
   };