Coverity fixes for 2.0b3 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close file descriptor in case of error
Delete identical branch
Ensure we have NULL terminator
Move the allocation and big arrays into scope where it is needed
Free the struct at the end of function
Ensure that PrinterPlanes is not zero
Alloc the array only in case we need it to prevent overwriting pointer
Use default branch instead of specific one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Till,
I did a coverity scan for cups-filters during the rebase and the following
issues were found - I fixed them by commits in this PR - would you mind merging it?