Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode CSS #152

Conversation

slinkouswasalreadytaken

Added dark, more modern style based on Safari 14's dev tools

Added dark mode based on Safari 14's dev tools
@slinkouswasalreadytaken slinkouswasalreadytaken marked this pull request as ready for review March 18, 2021 17:57
@michaelrsweet michaelrsweet self-assigned this Mar 18, 2021
@michaelrsweet michaelrsweet self-requested a review March 18, 2021 18:02
@michaelrsweet michaelrsweet added enhancement New feature or request priority-low labels Mar 18, 2021
@michaelrsweet michaelrsweet added this to the v2.4.0 milestone Mar 18, 2021
@michaelrsweet
Copy link
Member

Thanks! There are other web interface changes that are coming but I'll make sure we incorporate this change for 2.4.0.

@jschwender
Copy link
Contributor

Looks like the default mode is turned to dark mode, which i think is not a good idea: Dark modes are not proven to be better. Scientific research proves that this mode does not help office-eye-syndrom, and even Apple recommends it's use only for specific environment. Therefore, the right way to go is clearly to respect the desktop mode choosen by the end user, not to turn everything to dark, this is just chasing hype. Give the choice to the user.

@michaelrsweet
Copy link
Member

@jschwender The final changes will use a media selector to honor the user's chosen color scheme, e.g.:

/* Dark mode overrides */
@media (prefers-color-scheme: dark) {
  ...
}

Whether people will be staring at the CUPS web interface in the dark, I don't know... I hope not! :)

@michaelrsweet
Copy link
Member

[master 3daea66] Add dark mode CSS for web interface (Issue #152)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants