backend/ipp: Change handling of job_canceled #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job_canceled can be -1, 0, or 1. 0 indicates no error, 1 indicates that we were cancelled in normal operations (user cancelled from computer) and -1 indicates cancelled by printer. There is clearly an assumption that -1 is false since there is a check for job_canceled < 0 a few lines later. BUG=b:174793115 TEST=Print to printer with malformed PWG-Raster content Change-Id: I88f504d00e0680507cd439b633c6c288cf7c5390
michaelrsweet
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job_canceled can be -1, 0, or 1. 0 indicates no error, 1 indicates
that we were cancelled in normal operations (user cancelled from
computer) and -1 indicates cancelled by printer. There is clearly
an assumption that -1 is false since there is a check for
job_canceled < 0 a few lines later.