New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian: Run testlang for each CUPS locale #85
Conversation
… and only for these. Of the build environment forces LC_ALL to a non-provided locale, the build will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem with this change is that on macOS the locale testing loops through the system-defined locales. It would be better for testlang to loop through the locales it finds in the locale directory on platforms other than macOS.
Hrm. That's what this does; isn't it? |
No, your change removes the testing of macOS locales and scripts the testing of configured languages. What I want to see is the loop over configured languages to be put in the testlang program itself, so that on macOS we can continue to test all system locales (which have been a historical source of problems) and on Linux/others we can test all configured locales. The macOS code starts on line 185 of testlang.c, we just need to adapt it to test all the locales in the "locale" directory. |
OK. On second reading, I got what you meant. Unfortunately, I don't have a MacOS at hand to implement this. |
@OdyX Nothing to implement, just do your test with an |
Also refactored the locale test code into a separate function, updated the output to be consistent with the other unit tests, and split out the macOS language identifier tests. Still need to move the PPD tests to the testppd program.
… and only for these.
Of the build environment forces LC_ALL to a non-provided locale, the build will fail.
For instance, the Debian reproducible builds' initiative runs builds under arbitrary locales; specifically the
testlang
make target will fail when run withLC_ALL=kz_KZ
for example.