made libcupsfilters support both libcups2 and libcups3 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taining macros to support libcups2 aswell as libcups3
…t libcupsfilter supports both libcups2 and libcups3
| # define cupsArrayGetFirst cupsArrayFirst | ||
| # define cupsArrayGetElement cupsArrayIndex | ||
| # define cupsArrayNew cupsArrayNew3 | ||
| # define cupsGetsDests cupsGetDests2 |
There was a problem hiding this comment.
It should probably be cupsGetDests and not cupsGetsDests here.
| @@ -22,6 +22,7 @@ | |||
| #include <ctype.h> | |||
| #include <limits.h> | |||
| #include <stdlib.h> | |||
| //#include <scheduler/printers.h> | |||
There was a problem hiding this comment.
Please remove this commented-out line.
| @@ -30,6 +31,7 @@ | |||
| #include <cups/cups.h> | |||
| #include <cups/backend.h> | |||
| #include <cups/dir.h> | |||
| #include <cups/http-private.h> | |||
There was a problem hiding this comment.
Do not use private (library-internal) APIs in other programs/libraries. They are not stable APIs and can change at any time.
| // | ||
| // Contents: | ||
| // | ||
| // main() - Main entry... |
There was a problem hiding this comment.
Looks like that you have copied this header from another file. Please update it, especially line 2 and line12.
|
Please also make sure that your PR is based on the current GIT master state of libcupsfilters. |
|
Solved differently via commit 26f9c3f But thanks anyway for your pull request which provided a good base for the final solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed libcupsfilters API call that it was making from libcups2 so that its compatible to version 3 of libcups. Added libcups2-private.h with certain macros, so that its compatible to the version 2 of libcups.