Skip to content

Commit

Permalink
Removed patches to lift CUPS' internal security features
Browse files Browse the repository at this point in the history
Now, as we replace CUPS' privilege-drop user "lp" for the filters and
backends by the Snap's standard privilege-drop user "snap_daemon" and
also check the system for a suitable group for CUPS administration, we
do not need to lift CUPS' restrictions any more which we did to run
CUPS all-root.

So we are removing here the patches for

- allowing root as user for the filters and backends
- allowing the filter/backends group to be under the admin groups
- allowing to run the helper program cups-deviced as root
  • Loading branch information
tillkamppeter committed May 26, 2020
1 parent 7844bc9 commit d81e6ed
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 45 deletions.
11 changes: 0 additions & 11 deletions patches/cups-deviced-allow-run-by-root.patch

This file was deleted.

11 changes: 0 additions & 11 deletions patches/cupsd-allow-group-and-systemgroup-be-the-same.patch

This file was deleted.

20 changes: 0 additions & 20 deletions patches/cupsd-allow-root-as-cups-user.patch

This file was deleted.

3 changes: 0 additions & 3 deletions snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ parts:
set -eux
patch -p0 < $SNAPCRAFT_STAGE/patches/cupsd-pass-on-ld-library-path.patch
patch -p0 < $SNAPCRAFT_STAGE/patches/cupsd-pass-on-path.patch
patch -p0 < $SNAPCRAFT_STAGE/patches/cupsd-allow-root-as-cups-user.patch
patch -p0 < $SNAPCRAFT_STAGE/patches/cupsd-allow-group-and-systemgroup-be-the-same.patch
patch -p0 < $SNAPCRAFT_STAGE/patches/cups-deviced-allow-run-by-root.patch
patch -p1 < $SNAPCRAFT_STAGE/patches/cups-airprint-support.patch
patch -p1 < $SNAPCRAFT_STAGE/patches/cupsd-extra-check-for-admin-tasks-snap-cups-control.patch
patch -p1 < $SNAPCRAFT_STAGE/patches/libcups-fix-convert-option-choice-names-in-ppd.patch
Expand Down

0 comments on commit d81e6ed

Please sign in to comment.