Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for autoconf 2.70 needed #201

Closed
andyrtr opened this issue Jan 6, 2021 · 3 comments
Closed

fix for autoconf 2.70 needed #201

andyrtr opened this issue Jan 6, 2021 · 3 comments

Comments

@andyrtr
Copy link

andyrtr commented Jan 6, 2021

With recent autoconf 2.70 you will get this error when running autoreconf -vfi:

configure.ac: error: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION

I could solve it adding this small patch. Not sure if gettext 0.21 is needed or even an older version would do it.

+++ system-config-printer-1.5.14/configure.ac.new       2021-01-06 10:38:51.997694866 +0100
@@ -3,6 +3,7 @@
 AM_INIT_AUTOMAKE([dist-xz dist-bzip2 subdir-objects 1.6])
 IT_PROG_INTLTOOL
 AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT_VERSION(0.21)
 AM_PATH_PYTHON([3])
 PACKAGE="AC_PACKAGE_NAME"
 VERSION="AC_PACKAGE_VERSION"```

And please add the missing README file to avoid another autotools error. I've added "touch README" to our Arch packaging script for a long time.
@zdohnal
Copy link
Member

zdohnal commented Jan 6, 2021

Hi @andyrtr ,

thank you for reporting the issue!

My Fedora rawhide has only autoconf 2.69, would you mind testing if adding the following line in configure.ac works?

AM_GNU_GETTEXT_VERSION([0.18.3])

I chose this version because it is the same version as cups-filters requires and I would like to require the same version as other projects of printing stack.

@andyrtr
Copy link
Author

andyrtr commented Jan 6, 2021

Works well too here.

zdohnal added a commit that referenced this issue Jan 6, 2021
Autoconf 2.70 requires GETTEXT version now.
zdohnal added a commit that referenced this issue Jan 6, 2021
Autoconf needs it, fails otherwise.
@zdohnal
Copy link
Member

zdohnal commented Jan 6, 2021

Fixed on the current master.

Thank you for the report and testing!

@zdohnal zdohnal closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants