Generate WP posts with rich layout including multimedia etc #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x HTML to render any images, YouTube videos, Tweets, iframes, or JavaScript-based widgets within the post in the order they appeared on the NPR website.
…Press Media Library instead of all referenced images in the story
tamw-wnet
requested review from
davidmpurdy and
jwcounts
and removed request for
a team
jwcounts
approved these changes
Jan 20, 2022
|
@jwcounts I think you actually have to make a request to NPR to have the 'layout' stuff added to your key. |
|
Okay, waiting to hear back from NPR Support. I'm good with merging in the meantime. |
|
I'm going to add some help text to the README and/or the settings page so people know how to enable 'layout' for their keys. "They should open a ticket requesting layout permissions for their Story API Key. Have them please provide the key in the request so we can make sure we know which one we're adding those permissions to." |
|
Sounds good
Jared Counts
Sent from my Mobile Command Center
… On Jan 21, 2022, at 09:44, William Tam (WNET) ***@***.***> wrote:
I'm going to add some help text to the README and/or the settings page so people know how to enable 'layout' for their keys. "They should open a ticket requesting layout permissions for their Story API Key. Have them please provide the key in the request so we can make sure we know which one we're adding those permissions to."
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Updating the text for the layout checkbox explaining that it may require a ticket with NPR to update their Story API key to get the layout section.
|
@jwcounts I've added the help text -- I'm going to let you make that request to NPR so you can see what the behavior is with the layout stuff before pushing this forward. |
jwcounts
reviewed
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NPR Story API includes a 'layout' section for most stories that references inline the placement of multimedia objects such as images, videos, Twitter embeds, javascript widgets, etc. This pull request adds the ability for the WP site admin to import stories using that rich layout including the multimedia objects, in the order they appeared in the NPR.org story. It adds a checkbox to the admin to enable this functionality. As of this commit, Slideshows are not imported, only the first image in the slideshow.