Prevent spamming output with 'Not realizable' #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ODE solver encountered an unrealizable situation, it sent the string 'Not realizeable' to the terminal each time the local time step was adjusted. This spammed the terminal/logs and was somewhat uniformative to new users and has been accidnetally considered a failed run, rather than part of the ODE solution process. The string is now only output the first time the local time step is adjusted and has been reworded to hopefully reduce confusion.
|
Something is up with the files changed in this PR - I've only edited realizableOdeSolver.C & realizableOdeSolver.H. I may have goofed something in forking or creating the PR, since I'm not terribly experienced in multiuser, multibranch git workflows. |
|
Thank you for your PR. I agree the message was not particularly informative. The workflow we have is quite simple and what you have followed is perfectly fine. I think the problem with the additional commits is on my side. It looks like our development branch on GitHub is missing some of those commits, but I have them locally. I am going to look into that and then merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. I'm not entirely sure of the development flow for this project. I've created a fork, tested my code in the development branch, and am creating a pull request. I'm also opening an issue in the parent repository to associate with this PR. I've tried to make an informative commit message, but it looks like you might have your own format. Happy to adjust things.
When the ODE solver encountered an unrealizable situation, it sent the string 'Not realizable' to the terminal each time the local time step was adjusted. This spammed the terminal/logs and was somewhat uninformative to new users and has been accidentally considered a failed run, rather than part of the ODE solution process. The string is now only output the first time the local time step is adjusted and has been reworded to hopefully reduce confusion.