Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a shipped example of a PNG8 setup. #119

Closed
GraionDilach opened this issue Nov 7, 2018 · 12 comments
Closed

There should be a shipped example of a PNG8 setup. #119

GraionDilach opened this issue Nov 7, 2018 · 12 comments

Comments

@GraionDilach
Copy link

Even the source code is unclear about how to set up the metadata properly, so the best would be to extract it from an already existing PNG, but there isn't such in the first-party.

The best suggestion I would make in this regard is to port the lighthouse from RA to TD, but letting it stay within RA palette, so that it can feature both usecases as an asset and as a palette.

@IceReaper
Copy link
Contributor

IceReaper commented Nov 7, 2018

Example png i use for my custom mousecursors: (metadata included)
Cursors
Cursor usage:

Cursors:
	bits/Cursors.png: kknd
		sell:
			Start: 0
			Length: 12
		sell-blocked:
			Start: 19

And the shared palette i am using for my whole kknd project:
Palette
Palette usage:

^Palettes:
	PaletteFromPng@kknd:
		Name: kknd
		Filename: bits/palette.png
		CursorPalette: true

Hope this helps as example :)

@reaperrr
Copy link

reaperrr commented Nov 8, 2018

Added link to OpenRA/OpenRA#15336 since that's where people arriving from the changelog entry will look first.

@GraionDilach
Copy link
Author

The examples have been deleted.

@GraionDilach
Copy link
Author

Please consider this part of Next+1 with shipping, say, the lighthouse in PNG8 format, to prevent cases like OpenRA/OpenRA#17069.

@yaaaaa
Copy link

yaaaaa commented Sep 9, 2019

Yes, i use utility to make sequense.png file tith information about frames, but i have a questions abut palette and playercolor. instuction is needed...

  1. playercolor colors must be same in all png files?
  2. palette must be same in all png files?

@pchote pchote transferred this issue from OpenRA/OpenRA Sep 9, 2019
@pchote
Copy link
Member

pchote commented Sep 9, 2019

Transferred to the Mod SDK repository. The natural solution here is to include this as part of the getting started guide.

@yaaaaa
Copy link

yaaaaa commented Sep 9, 2019

Please tell about invisible background color in the png files or its palette too.

@GraionDilach
Copy link
Author

The obvious solution is to provide an example in the base games somewhere. Not everyone starts at the ModSDK.

Closed because it's out of scope for the ModSDK to explain something the documentation should.

@ghost
Copy link

ghost commented Sep 10, 2019

The documentation can point to the modSDK example. I think the chances that the functional examples here get updated as part of the release process are higher than that the wiki (there is no real documentation) in OpenRA/OpenRA gets updated. Reposted so we don't lose this.

@GraionDilach
Copy link
Author

OpenRA/OpenRA#15336 (comment) was the thing I repeated constantly, thank you for your ignorance, lack of understanding and lack of respect regarding my tickets - not surprised at all though you have the face to do this though.

Risking regressions because of lack of official testcases to obfuscate features just proves mods are second-hand clients, as usual from OpenRA.

Also, the wiki pages are used as modder documentation - or will the autogenerated Traits and Lua API sites gets transferred to this wiki as well based on this logic?

@ghost
Copy link

ghost commented Sep 10, 2019

OpenRA/OpenRA#15336 (comment) was the thing I repeated constantly, thank you for your ignorance, lack of understanding and lack of respect regarding my tickets - not surprised at all though you have the face to do this though.

You took this way too personal. It's just about the question where the examples live and nothing has been decided. Since you closed your ticket, I explained my opinion on the matter in the new one.

Risking regressions because of lack of official testcases

My idea was that these testcases could easier be maintained here in a bare environment. I thought that such basic feature testcases can be reviewed during the release process. As not all features might be used in the production mods, it makes sense in my opinion to have testcases of them in one central place. Perhaps I'm misunderstanding the issue, but my idea understanding of the earlier comment was to address the problem of unnoticed regressions (provided the testcases are reviewed as part of the release process).

Also, the wiki pages are used as modder documentation - or will the autogenerated Traits and Lua API sites

Autogenerated is the keyword here. Those pages do not need any maintenance by definition. The other wiki pages and guides are not regularly updated. The wiki has also only limited functions compared to a "real" repository.

transferred to this wiki as well based on this logic?

My idea / understanding of the earlier comment was that these testcases would be functional complete examples and lived somewhere within the source code of the example mod.

@Mailaender
Copy link
Member

This was resolved by OpenRA/OpenRA#17471.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants