Drop PREFIX macro and fix for Gentoo prefix #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: it conflicts with a9272f5 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops PREFIX macro, as another way of fixing for Gentoo prefix (the other way is enabling this macro in meson build system, see #672)
However, one commit breaks the a9272f5, by re-introducing prefix to
/rundirectory, because Gentoo prefix may not have access to the unprefixied/run. That affects archlinux install, and perhaps merged/usrprofilePlease review and judge which is the better way. Keep PREFIX macro, #672, or drop it, implemented in this PR?