Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-DE: Update strings from 6586 to 6592 #2668

Merged
merged 6 commits into from
Jul 4, 2023
Merged

de-DE: Update strings from 6586 to 6592 #2668

merged 6 commits into from
Jul 4, 2023

Conversation

Gr33ndev
Copy link
Contributor

@Gr33ndev Gr33ndev commented Jul 3, 2023 •
edited
Loading

Applying for issue(s):

My commit for the contributors file takes place in this PR: OpenRCT2/OpenRCT2#20552

@Gr33ndev Gr33ndev mentioned this pull request Jul 3, 2023
Merged
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
de-DE 0 (-7) 1 352 (+1)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 7 1 116
cs-CZ 380 0 246
da-DK 119 1 484
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
it-IT 63 1 339
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
de-DE 0 (-7) 1 352 (+1)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 7 1 116
cs-CZ 380 0 246
da-DK 119 1 484
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
it-IT 63 1 339
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

@Gr33ndev
de-DE: rename "Fensterschaltflächen" to "Schaltflächen"
1d971ef 
I researched it and microsoft is calling them "Schaltflächen" in german
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
de-DE 0 (-7) 1 352 (+1)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 7 1 116
cs-CZ 380 0 246
da-DK 119 1 484
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
it-IT 63 1 339
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

tupaschoal
tupaschoal reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for volunteering to translate! From my perspective it looks good. Since @Wuzzy2 has been maintaining de-DE for a while, I'll give them a couple days to review

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Jul 4, 2023

Rofl, I just completed my translation only to see it was already done by someone else.

Anyway, this translation PR is good. 👍

(FYI: I tend to post translation PRs around month changes.)

@Gr33ndev
Copy link
Contributor Author

Gr33ndev commented Jul 4, 2023 •
edited
Loading

Sorry for the unnecessary work, I didn't know you were also working on it 😅

@tupaschoal tupaschoal merged commit 5f198a6 into OpenRCT2:master Jul 4, 2023
1 check passed
@tupaschoal
Copy link
Member

Thanks @Gr33ndev and @Wuzzy2 .

@Gr33ndev if you wish to become a regular de-DE maintainer, we have a system to have you notified and such, just let us know.

@Gr33ndev
Copy link
Contributor Author

Gr33ndev commented Jul 4, 2023

You‘re welcome!

Sure, let me know when there is something to translate to German :)

@Gr33ndev Gr33ndev deleted the apply-6591-6592 branch July 4, 2023 20:07
@tupaschoal
Copy link
Member

Can you do a PR to add yourself? Should be pretty similar to this one 3142e92

@Gr33ndev
Copy link
Contributor Author

Gr33ndev commented Jul 4, 2023

Sure: #2669
Hope I did it right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gr33ndev @Wuzzy2 @tupaschoal