Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff patrol areas get duplicated/linked in scenarios that already contain staff #13500

Open
2 tasks
xperia64 opened this issue Dec 2, 2020 · 2 comments
Open
2 tasks
Labels
investigate Not sure what the problem is yet. rct1 Relates to RollerCoaster Tycoon 1.

Comments

@xperia64
Copy link
Contributor

xperia64 commented Dec 2, 2020

OS: Windows 10
Version: 0.3.2
Commit/Build: aa8a089

When starting a new game in a scenario where staff are already present (at least in RCT1 scenarios), if more staff are hired by the player and the patrol area of the new staff is set, the pre-existing staff will have their patrol area set to that of the new staff. I've definitely seen this in Karts & Coasters, but I believe I may have also seen this behavior in Katie's World and Aqua Park.

  • Reproducible in RCT2 (vanilla)?
  • Specific to multiplayer?

Steps to reproduce:

  1. Start a new game with the Karts & Coasters Scenario
  2. Note the existing Handyman and Mechanic
  3. Hire a single new Handyman and set his patrol area
  4. The Mechanic should now have a patrol area that matches the new Handyman, at least in the Staff UI
  5. Hire a second new Handyman and set his patrol area
  6. The original scenario Handyman should now have a patrol area that matches second new Handyman

Save game:
Attached is a save file of Karts & Coasters after performing the above steps. It seems the linked patrol areas persist in saves.
Karts & Coasters Handyman Example.zip

@duncanspumpkin
Copy link
Contributor

Sounds like an rct1 import issue. Patrols are tied to the staff id (different to sprite id). Sounds like the global next free staff id is incorrect.

@duncanspumpkin duncanspumpkin added investigate Not sure what the problem is yet. rct1 Relates to RollerCoaster Tycoon 1. labels Dec 2, 2020
@galfisk
Copy link

galfisk commented Jan 24, 2021

I see this as well. The patrol area affects both staff members (i.e. they stay inside it of they walk into it), and changing it for one will change it for the other, so they're permanently linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Not sure what the problem is yet. rct1 Relates to RollerCoaster Tycoon 1.
Projects
None yet
Development

No branches or pull requests

3 participants