Crash when scrolling through Advanced Object Selection

[Electrollama]

OS: Ubuntu 20.04.1 LTS
Version: 3.2 (also noticed in several older versions)

When I am selecting objects in the Scenario Editor, the game suddenly crashes. It seems to happen at a random time, but I notice it happens when scrolling through the Small Objects list, but not at any particular position. The crash happens pretty much every time I am using the menu for an extended period of time, ~15 minutes. I have noticed this crash in the past but didn't bother reporting it.

Steps to reproduce:

1. Open the Scenario Editor
2. Go to object selection
3. Enable Advanced, Filter to exclude OpenRCT2 and Custom content but enable all others, filter selected only
4. Enable several scenery themes from RCT1 and RCT2 + expansions
5. Make selections in Small Objects (and maybe other scenery lists) for several minutes
6. The game eventually crashes while scrolling through the list

[ocalhoun6]

Also experiencing that crash ... just had it happen for the first time today.

And I'm not sure if this is a coincidence or not, but I'm also on (a version of) Ubuntu 20.04.

Has anyone experienced it on other operating systems?

[Gymnasiast]

You removed the build/commit field. It is there for a reason. Please fill it in.
There is also no such version as "3.2". Our most recent release is 0.3.2.

[Electrollama]

Update on the bug:
Version: 0.3.2-develop-0 ~ 2073-202011291937-ga7481b40b ~ ubuntu20.04.1
Video: https://clips.twitch.tv/VenomousGeniusPresidentM4xHeh

I discovered 3 seemingly different types of crashes with repeatable setup. I have experienced a few similar crashes that seem purely random and doesn't use these setups.

Geometric Sculpture bug:

1. Open Scenario Editor, Object Selection
2. Click "Advanced"
3. Open "Small Scenery" tab
4. Scroll through the list, find Geometric Sculpture (any one, such as the glass cube)
5. Hover the cursor over the text "Geometric Sculpture". This causes the game to crash.

Unchecked object bug:

1. Open Scenario Editor, Object Selection
   [optional] enable other scenery groups
2. Click "Advanced", In filters, enable "Selected Only"
3. Open "Large Scenery" tabs
4. Uncheck (almost) any object
5. Hover the cursor over where the object used to be. This causes the game to crash.
6. If this doesn't work, keep trying with other objects. It works every time with the "Ice Palace".

Searched item bug:

1. Open Scenario Editor, Object Selection
2. Open "Large Scenery" tabs
3. Type letters so that 1-5 objects appears in the list. (Ex. "lla" for the Golden Llama)
4. Check an object
5. Hover the cursor over the selected object. This causes the game to crash.

[IntelOrca]

Are these debug builds? Ones that might trigger asserts?

[Electrollama]

Yes, the "version" according to "openrct2 --version" is "OpenRCT2, ( on , DEBUG) Linux (x86-64)"

I figured out I can get the crash log if I just run OpenRCT2 through the terminal.
ObjectSelectionCrashDump.txt

[Electrollama]

And here is the output when running with "--verbose":
Unchecked object bug:
ObjectSelectionCrashDump2.txt
Geometric Sculpture bug:
GeometricSculptureCrashDump.txt
Searched item bug:
SearchedLargeObjectCrashDump.txt

[IntelOrca]

In that case, I believe it is a duplicate of #11875.

The issue is not present in release builds, where asserts are disabled.

[ocalhoun6]

@IntelOrca
The only difference I see in the two issues is that 11875 seems to only mention custom objects, while this issue is happening (at least in my case) with strictly vanilla NCSO objects. I have no custom objects in my entire installation, and I'm still getting this crash sometimes.

So if it is due to faulty objects those objects should probably be fixed.
(Or maybe some error handling so that it throws up an error rather than crashing the whole game?)

[IntelOrca]

Hmm, I can't reproduce the assert on those geometric sculptures in a Windows debug build.

[ocalhoun6]

Maybe it has something to do with a case-sensitive filesystem?

[Electrollama]

On the AppImage (Ubuntu executable) version, the crash does not occur, but there is still a message that an assertion failed. Except for the geometric sculpture, no assertion message for that bug.

[IntelOrca]

Some of the issues are related to freeing image lists which is a different issue and not specific to a particular object.