Mechanic will inspect lift/boat hire even though it cannot break down

[beam41]

Operating System

Windows 11 64 bit

OpenRCT2 build

OpenRCT2, v0.4.1-361-ga8073f6 (a8073f6 on develop) provided by GitHub

Describe the issue

In original rct2 and openrct2 mechanic does ignore the ride that cannot break down like crooked house.

However, they still inspect lift and boat hire (rowing boats, swans, and canoes boat hire cannot break).

In original rct2

In openrct2

I suspect that because lift and boat hire have breakdown type, the mechanic will inspect them, but they do not check if the ride can actually break.

Area(s) with issue?

The bug also exists in RCT2 (vanilla)

Steps to reproduce

1. has a park with enough mechanic to inspect all ride and unbreakable ride with lift and boat hire (rowing boats, swans, and canoes)
2. Run the park for very long time
3. check the ride that cannot break (Marcel has video for them)
4. All unbreakable ride will have very high time since last inspection, except lift and boat hire which has time within inspection range.

Attachments

My park use in testing
Testbreak.zip

[Gymnasiast]

The lift can most certainly break down, and so can Boat Hire, although only if it’s using motorised boats (Bumper Boats, Jet Skis).

[beam41]

@Gymnasiast and I think that means we have to check if we have to check if ride need inspection base on vehicle type, but it might not worth fixing, I understand why you close.

I never seen lift break without cheat tho.

[ocalhoun6]

Just to be sure, I ran a quick test:

Ran 7 lifts for over 10 in-game years, with no inspections -- none of them ever broke down.

[Gymnasiast]

I did some digging and found this out: while the Lift ride can break down, its vehicle, for a reason I don’t understand, set a flag that prevents them.

I can’t say I understand it, seems like an error to me.

[beam41]

As Marcel said in his video. If it can breakdown, we need mechanic at the top if path not connects to the below, but he also points out it might be a bug.

Maybe Chris Sawyer make lift breakdown like other ride first, then realized that the problem could happen. So he decided to kinda band aid fix by set flag to never break.

[beam41]

I change the check from ride->GetRideTypeDescriptor().AvailableBreakdowns == 0 to !ride->CanBreakDown() and it fix the issue and work fine even when I force breakdown using cheat

Should I make the pull request for this now?

[Gymnasiast]

@beam41 Yes, that seems sensible to me.

[beam41]

Ok, might set Inspection never and make it grayed out as well.