Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slope track piece not rendered at tunnel entrance directly under horizontal surface #18389

Open
cheweytoo opened this issue Oct 19, 2022 · 9 comments
Labels
bug Something went wrong. graphics Relates to how graphics are rendered and displayed on screen. z-fighting

Comments

@cheweytoo
Copy link

cheweytoo commented Oct 19, 2022

Operating System

Ubuntu Linux 20.04.5

OpenRCT2 build

f91df41 develop

Describe the issue

Basically the same thing as #18376, but this time direction dependent: The slope track piece of any coaster that has this piece available is not rendered in a tunnel entrance directly under flat land. while the corresponding upslope piece on exiting a tunnel does show up.

mine_train_noslope

Edit: Turns out it depends on the amount of land above, the upslope piece is affected too:
upslope

As with #18376, using "Hide Vertical Faces" makes the track piece appear.

So this is probably an original bug as well.

Area(s) with issue?

No response

Steps to reproduce

Build a "Mine Ride" entering a vertical wall on a downward slope. Or see attached park.

Attachments

mine_ride_noslope.zip

@cheweytoo cheweytoo added the bug Something went wrong. label Oct 19, 2022
@Gymnasiast Gymnasiast added the graphics Relates to how graphics are rendered and displayed on screen. label Oct 20, 2022
@jensj12
Copy link
Contributor

jensj12 commented Oct 20, 2022

You're chopping their heads off. Raise the ground one unit and the track piece will show, along with a larger tunnel (which is how it works (or used to work) for all tracked rides that enter a tunnel sloped).

@Broxzier
Copy link
Member

Did you build that track with clearance checks disabled?

@cheweytoo
Copy link
Author

You just made me check again, but no: This is a completely legal build without any cheats.

So I'd argue that while indeed more land on top makes the render change, this is still a bug.

@cheweytoo cheweytoo changed the title "Mine Ride" downslope track piece not rendered at tunnel entrance "Mine Ride" slope track piece not rendered at tunnel entrance directly under horizontal surface Oct 20, 2022
@cheweytoo
Copy link
Author

OK, I just used "arbitrary ride type changes" to cycle through most of the track types, and it seems all are affected.

Is the actual bug here that this is buildable?

@jensj12
Copy link
Contributor

jensj12 commented Oct 23, 2022

It is buildable like this in vanilla RCT2 and even RCT1. You need 2 units of height to build a tunnel, but on a slope there is only 1.5 units of clearance. Giving it a third unit makes it use the full 2 height units.

@cheweytoo cheweytoo changed the title "Mine Ride" slope track piece not rendered at tunnel entrance directly under horizontal surface Slope track piece not rendered at tunnel entrance directly under horizontal surface Oct 24, 2022
@cheweytoo
Copy link
Author

So it's intentionally buildable then. That makes this a rendering bug :-)

I've updated title and description.

@karst
Copy link
Member

karst commented Dec 11, 2022

I think lowering the "flat" tunnel's bounding box by 8, or expanding it by 8 on the bottom, would fix all these bugs, even the one I fixed before by changing the bounding boxes of the helixes (so we could revert that). I do wonder how difficult it is to access these bounding boxes but it's something I could look into

@ocalhoun6
Copy link
Contributor

Paying attention to this a bit more, I've noticed something weird: this bug does not occur if the virtual floor is visible anywhere on the screen. The virtual floor doesn't even have to be anywhere near the tunnel entrance. If the virtual floor is displayed anywhere, this bug goes away.

Without virtual floor:
Giggle Downs 2022-12-12 12-19-51

With virtual floor:
Giggle Downs 2022-12-12 12-19-47

@karst
Copy link
Member

karst commented Dec 12, 2022

similar to any other thing the floor is just another sprite placed on top or under it. In this case I think the bounding boxes match one another so the priority changes if another sprite is added on top or under it and it shows again. It's why the corrupt element used to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong. graphics Relates to how graphics are rendered and displayed on screen. z-fighting
Projects
None yet
Development

No branches or pull requests

7 participants