Mini Golf Hole D and E have incorrect underground boundbox

[Gymnasiast]

Operating System

Ubuntu 22.04

OpenRCT2 build

286f010

Describe the issue

Not affected by #18404.

Area(s) with issue?

No response

Steps to reproduce

Build Mini Golf Hole E underground. Is likely to apply to other holes as well.

Attachments

No response

[raacker]

@Gymnasiast Thanks for creating another issue ticket. I played around a bit but I think I really couldn't understand BoundingBox Size and offset values. For me, feel like hard coded magic numbers.

OpenRCT2/src/openrct2/ride/gentle/MiniGolf.cpp

Lines 1006 to 1026 in 286f010

	switch ((direction << 4) | trackSequence)
	{
	case 0x01:
	case 0x32:
	PaintAddImageAsParent(session, imageId, { 0, 0, height }, { 2, 26, 3 }, { 30, 3, height + 4 });
	break;
	case 0x02:
	PaintAddImageAsParent(session, imageId, { 0, 0, height }, { 23, 2, 3 }, { 3, 30, height + 4 });
	break;
	case 0x10:
	PaintAddImageAsParent(session, imageId, { 0, 0, height }, { 2, 24, 3 }, { 30, 3, height + 4 });
	break;
	case 0x20:
	case 0x31:
	PaintAddImageAsParent(session, imageId, { 0, 0, height }, { 26, 2, 3 }, { 3, 30, height + 4 });
	break;
	default:
	PaintAddImageAsParent(
	session, imageId, { 0, 0, height }, { boundBox.x, boundBox.y, 0 },
	{ boundBoxOffset.x, boundBoxOffset.y, height + 24 });
	break;

I can tell it definitely has z fighting issue and would be resolved by bounding box values.

[Gymnasiast]

People like @rik-smeets and @karst have done this before, so I expect one of them to look into it.

[Derpercoaster]

For me, z-fighting doesn't ruin the game experience. It's just part of the game's endless charm. Whenever I run into it, I never think "oh great, not this again!" but instead think "how can I build this so I don't see the bug?" I design my park around bugs, which makes them feel like part of the game.