New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jansson dependency #5050
Comments
@susnux thanks for you report. Do you want to fix it for 2.4? If not, I'll up the required version to 2.5. |
On second thought, I'll just update the version to 2.5. I only lowered it because we used to use 2.7, which introduced a macro Since then we've moved to building on 16.04 using docker. Arch jobs also have much more recent jansson version. |
Yes I also think this is the best solution since I can not make sure it will work 100% with 2.4. |
@susnux are you by any chance handling https://build.opensuse.org/package/show/games/openrct2 ? Regarding chosen solution: we do intend to use progressively more of modern C++'s features and supporting old platforms comes at a cost to maintenance. Isn't openSUSE 13.1 obsolete by now? I thought it was at ~42 as of these days. |
Yes I am an openSUSE:games maintainer, 0.0.5 is on its way into the openSUSE repositories ;-) And yes 13.1 is quite old, but there are still some users (LTS version) so I always try to get packages run on as much versions as possible, if not (as in this case) then not, but I do my best. |
@susnux nice. Most of our users are expected to be running a current version of We have a semi-supported PPA for deb-based systems and Arch (my distro) has https://aur.archlinux.org/packages/openrct2-git. Any chance of having similar package for your system? |
The readme and the wiki says that jannson >= 2.3 is required.
But trying 2.3 (openSUSE 13.1 ships only 2.3.1) it does not compile.
First error:
Invalid conversion from const json_t* to json_t*
In src/network/http.cpp
args->request.body = json_deep_copy(request->body);
Jansson 2.3 only supports
json_deep_copy(json_t*)
.This only works with jansson >= 2.5 (or a const_cast).
Second error:
json_boolean
first appeared in 2.4.So either 2.4 is required with a const_cast addressing issue 1, e.g.
Or 2.5 or later is required (no changes).
The text was updated successfully, but these errors were encountered: