Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run AspNetCore E2E tests with NET8 on server #463

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Run AspNetCore E2E tests with NET8 on server #463

merged 20 commits into from
Dec 13, 2023

Conversation

Daniel-Svensson
Copy link
Member

@Daniel-Svensson Daniel-Svensson commented Nov 22, 2023 •
edited
Loading

.NET8

  • Build with dotnet8 sdk
  • Run AspNetCore E2E tests with .NET8 on server
  • Run AspNetCore tests on .NET8

Test improvements

  • improve test failure message from GetReferenceAssemblies
  • Verify AspNetCore webserver is started before executing e2e tests
  • Fix invalid handle from CrossProcessLoggingTests when debugger is attached

Build improvements

  • Set MSBUILDDEBUGPATH to allow troubleshooting of build failures
  • Stop installing dotnet (UseDotNet) for slightly faster build
  • remove appveyor file
  • Use msbuild directly in codeql
  • enable test diagnostics

@Daniel-Svensson
Copy link
Member Author

I believe it should be safe to merge thus once #458 is merged (it requires .net 8 sdk)

@Daniel-Svensson Daniel-Svensson marked this pull request as ready for review November 28, 2023 12:31
@Daniel-Svensson Daniel-Svensson force-pushed the aspnetcore_8 branch 2 times, most recently from 47cb023 to 508188c Compare December 4, 2023 21:54
@Daniel-Svensson
Copy link
Member Author

I believe failing aspnetcore e2e test is due to server not having started yet.

Should be fixed in assembly init by waiting for server to start

Daniel-Svensson
Daniel-Svensson commented Dec 13, 2023
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
@Daniel-Svensson Daniel-Svensson enabled auto-merge (squash) December 13, 2023 06:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Daniel-Svensson Daniel-Svensson merged commit 3f7ddc0 into OpenRIAServices:main Dec 13, 2023
5 checks passed
@Daniel-Svensson Daniel-Svensson deleted the aspnetcore_8 branch December 13, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SandstromErik SandstromErik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Daniel-Svensson @SandstromErik