Add support in DomainServiceTestHost for asynchronous queries that return a single entity #464
Conversation
* QuerySingleAsync with two overloads Expression<Func<TDomainService, TEntity>>, Expression<Func<TDomainService, Task<TEntity>>> queryOperation * Added overload for TryQuerySingle to handle async query
|
@dotnet-policy-service agree |
Daniel-Svensson
requested review from
lindellhugo and
SandstromErik
and removed request for
lindellhugo
Daniel-Svensson
assigned Daniel-Svensson and SandstromErik and unassigned Daniel-Svensson
There was a problem hiding this comment.
It seems that you changed CityDomainService so that there is a failing code generation test, which needs to be resolved.
You can run TestCityClientProxies and look at the output for instructions of how to update the code generation baseline.
The alternative is to use the AsyncServerSideDomainService (or similar named domain service) instead, it should have a queriy returning Task
src/Test/Desktop/OpenRiaServices.Common.DomainServices.Test/Cities/CityDomainService.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
This looks good so Feel free to merge @erikoijwall or @SandstromErik
I am wondering if we in the future should allow "Query" to be used for single entity returning methods as well (just add overloads which calls Single...)
src/OpenRiaServices.Server.UnitTesting/Framework/DomainServiceTestHost.cs
Show resolved
Hide resolved
erikoijwall
deleted the
feature/support_querysingle_domainservicetesthost
branch
Add support in DomainServiceTestHost for asynchronous queries that return a single entity
QuerySingleAsyncwith two overloadsExpression<Func<TDomainService, TEntity>> queryOperationExpression<Func<TDomainService, Task<TEntity>>> queryOperationAdded overload for
TryQuerySingleto handle async query