Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: introduce a switch initialization policy #2461

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

multun
Copy link
Contributor

@multun multun commented Nov 29, 2022

This initialization policy replaces the default switch configuration:

  • switches do not all have a default configuration
  • we may need to make pessimistic or optimistic assumptions, depending on the context

@multun multun requested a review from a team November 29, 2022 18:24
@multun multun force-pushed the switch-init-policy branch 2 times, most recently from 65200f6 to 5962c4b Compare November 29, 2022 18:42
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2461 (10a414c) into dev (73abb49) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #2461   +/-   ##
=========================================
  Coverage     80.04%   80.04%           
  Complexity     1661     1661           
=========================================
  Files           237      237           
  Lines          7393     7393           
  Branches        940      940           
=========================================
  Hits           5918     5918           
  Misses         1136     1136           
  Partials        339      339           
Flag Coverage Δ
core 83.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This initialization policy replaces the default switch configuration:
- switches do not all have a default configuration
- we may need to make pessimistic or optimistic assumptions, depending on the context
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo merged commit 6e7dc21 into dev Dec 5, 2022
@Khoyo Khoyo deleted the switch-init-policy branch December 5, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants