Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: fixing some issues on creation/update operation #2547

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Dec 9, 2022

Related to ticket #2503

/!\ This code breaks the update of a TrackSection : moving a point is not possible. But it will be fixed soon, on the branch where we remove the selection box /!\

@sim51 sim51 requested a review from a team December 9, 2022 09:32
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #2547 (1a4b413) into dev (f1fff5b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #2547      +/-   ##
============================================
- Coverage     37.62%   37.61%   -0.02%     
  Complexity     1661     1661              
============================================
  Files           551      551              
  Lines         16803    16808       +5     
  Branches       2350     2355       +5     
============================================
  Hits           6322     6322              
- Misses        10111    10116       +5     
  Partials        370      370              
Flag Coverage Δ
front 4.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/applications/editor/Map.tsx 0.00% <0.00%> (ø)
.../src/applications/editor/components/EditorForm.tsx 0.00% <0.00%> (ø)
...components/LinearMetadata/FormLineStringLength.tsx 0.00% <0.00%> (ø)
front/src/applications/editor/data/api.ts 0.00% <ø> (ø)
...lications/editor/tools/pointEdition/components.tsx 0.00% <0.00%> (ø)
...ications/editor/tools/pointEdition/tool-factory.ts 0.00% <0.00%> (ø)
front/src/utils/mapboxHelper.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacomyal jacomyal merged commit a0eeb5d into dev Dec 9, 2022
@jacomyal jacomyal deleted the bsi/fix-edtior branch December 9, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants