Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: tests: clean up stdcm unit tests #2622

Merged
merged 2 commits into from
Dec 20, 2022
Merged

core: tests: clean up stdcm unit tests #2622

merged 2 commits into from
Dec 20, 2022

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 16, 2022

Two main changes:

  1. Introduce a builder to make some parameters "optional" when calling STDCMPathfinding.findPath
  2. Split the main test class into several new classes

There's a lot of diff but functionally nothing really changed. It will avoid editing dozens of tests each time we add new parameters.

If someone wants to proofread, focus on this commit. The other commit where I move some code around makes the diff mostly irrelevant.

@eckter eckter requested a review from a team December 16, 2022 10:59
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2622 (caedc17) into dev (4ea6b69) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #2622      +/-   ##
============================================
- Coverage     37.31%   37.29%   -0.02%     
+ Complexity     1679     1678       -1     
============================================
  Files           578      578              
  Lines         17598    17598              
  Branches       2435     2435              
============================================
- Hits           6566     6564       -2     
- Misses        10655    10656       +1     
- Partials        377      378       +1     
Flag Coverage Δ
core 83.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/infra_state/implementation/TrainPathBuilder.java 81.94% <0.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eckter eckter enabled auto-merge (rebase) December 19, 2022 13:40
@eckter eckter disabled auto-merge December 19, 2022 13:40
Tguisnet
Tguisnet previously approved these changes Dec 19, 2022
multun
multun previously approved these changes Dec 19, 2022
@eckter eckter merged commit 0cf7d3a into dev Dec 20, 2022
@eckter eckter deleted the ech/clean-up-stdcm-tests branch December 20, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants