Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: only fetch simulation results if train_schedule_summaries is not empty #4530

Merged
merged 1 commit into from
Jul 7, 2023
Merged

front: only fetch simulation results if train_schedule_summaries is not empty #4530

merged 1 commit into from
Jul 7, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jul 6, 2023 •
edited
Loading

closes #4521

The bug comes from the fact that we fetch the simulation results even if the timetable has a train_schedule_summaries empty

@clarani clarani requested a review from a team as a code owner July 6, 2023 12:30
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Jul 6, 2023
SharglutDev
SharglutDev approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but lgtm :) (and +1000 for the renaming of getTimetable, it's on my todolist)

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #4530 (00b3e8c) into dev (43229e7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4530      +/-   ##
============================================
- Coverage     19.93%   19.93%   -0.01%     
  Complexity     2316     2316              
============================================
  Files           863      863              
  Lines         88059    88073      +14     
  Branches       2271     2271              
============================================
  Hits          17553    17553              
- Misses        69250    69264      +14     
  Partials       1256     1256
Flag Coverage Δ
front 9.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/ImportTrainSchedule/ImportTrainScheduleModal.jsx 0.00% <0.00%> (ø)
...erationalStudies/components/Scenario/Timetable.tsx 0.00% <0.00%> (ø)

flomonster
flomonster requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the issue when importing trains from open data.

multun
multun approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@multun multun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, the error is gone, thanks!

@clarani clarani force-pushed the cni/front/fix-timetable-simulation-results branch from 5a6a681 to d388a7e Compare July 6, 2023 22:27
flomonster
flomonster approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@flomonster flomonster force-pushed the cni/front/fix-timetable-simulation-results branch from d388a7e to 00b3e8c Compare July 7, 2023 02:47
@nicolaswurtz
Copy link
Contributor

Very good job 👍

@clarani clarani enabled auto-merge July 7, 2023 10:29
@clarani clarani added this pull request to the merge queue Jul 7, 2023
Merged via the queue into dev with commit 75a4df8 Jul 7, 2023
4 of 5 checks passed
@clarani clarani deleted the cni/front/fix-timetable-simulation-results branch July 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@multun multun multun approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@flomonster flomonster flomonster approved these changes

@anisometropie anisometropie anisometropie approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: TypeError: _e.train_schedule_summaries[0] is undefined
6 participants
@clarani @nicolaswurtz @multun @flomonster @anisometropie @SharglutDev