Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch delete endpoint for train schedules #4673

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

close #4576
close #4575

@Uriel-Sautron Uriel-Sautron added area:api (deprecated) Work on Api Service (deprecated) kind:feature-task Work related to a feature epic area:editoast Work on Editoast Service labels Jul 26, 2023
@Uriel-Sautron Uriel-Sautron force-pushed the usn/endpoint-delete-multi-train-api branch from 86a4797 to b5b9fb8 Compare July 26, 2023 10:33
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4673 (5a4efed) into dev (2cecaac) will increase coverage by 0.01%.
Report is 3 commits behind head on dev.
The diff coverage is 68.42%.

@@             Coverage Diff              @@
##                dev    #4673      +/-   ##
============================================
+ Coverage     19.97%   19.99%   +0.01%     
  Complexity     2323     2323              
============================================
  Files           869      869              
  Lines         88470    88510      +40     
  Branches       2283     2283              
============================================
+ Hits          17674    17699      +25     
- Misses        69535    69550      +15     
  Partials       1261     1261              
Flag Coverage Δ
editoast 61.69% <20.00%> (-0.03%) ⬇️
front 9.47% <75.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
editoast/src/views/train_schedule/mod.rs 6.32% <20.00%> (+0.44%) ⬆️
front/src/common/api/osrdMiddlewareApi.ts 91.75% <75.00%> (-0.24%) ⬇️
front/src/common/api/osrdEditoastApi.ts 91.49% <76.47%> (-0.13%) ⬇️

... and 7 files with indirect coverage changes

@Khoyo Khoyo force-pushed the usn/endpoint-delete-multi-train-api branch 2 times, most recently from 8ebe417 to c4a0fe6 Compare July 26, 2023 14:05
@Khoyo Khoyo marked this pull request as ready for review July 26, 2023 14:05
@Khoyo Khoyo requested a review from a team as a code owner July 26, 2023 14:05
@Khoyo Khoyo force-pushed the usn/endpoint-delete-multi-train-api branch 2 times, most recently from 8f2db54 to e9d6a38 Compare July 26, 2023 14:41
@Khoyo Khoyo requested a review from eckter as a code owner July 26, 2023 14:41
@Khoyo Khoyo force-pushed the usn/endpoint-delete-multi-train-api branch 2 times, most recently from 06009e0 to 6d80acd Compare July 26, 2023 16:09
Uriel-Sautron and others added 2 commits July 26, 2023 22:13
Co-Authored-By: Younes Khoudli <younes.khoudli@epita.fr>
Co-Author-By: Younes Khoudli <younes.khoudli@epita.fr>
@Khoyo Khoyo force-pushed the usn/endpoint-delete-multi-train-api branch from 6d80acd to 5a4efed Compare July 26, 2023 20:13
@Khoyo Khoyo added this pull request to the merge queue Jul 28, 2023
Merged via the queue into dev with commit aaf8d5a Jul 28, 2023
9 of 10 checks passed
@Khoyo Khoyo deleted the usn/endpoint-delete-multi-train-api branch July 28, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api (deprecated) Work on Api Service (deprecated) area:editoast Work on Editoast Service kind:feature-task Work related to a feature epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete multiple trains(Back API) Delete multiple trains(Back Editoast)
4 participants