Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: delete a scenario when deleting an infra #4808

Merged
merged 1 commit into from
Aug 22, 2023
Merged

api: delete a scenario when deleting an infra #4808

merged 1 commit into from
Aug 22, 2023

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Aug 13, 2023 •
edited
Loading

Close #3880

@younesschrifi younesschrifi requested a review from a team as a code owner August 13, 2023 21:04
@younesschrifi younesschrifi force-pushed the yci/delete_scenario_when_deleting_an_infra branch 5 times, most recently from 662f45d to 3ecea9e Compare August 13, 2023 21:17
leovalais
leovalais requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works fine, expect for the reverse_sql part which throws an error when unapplying the migration.

python/api/osrd_infra/migrations/0041_dead_section_cascade.py Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/delete_scenario_when_deleting_an_infra branch 2 times, most recently from 13f839f to 37c4685 Compare August 20, 2023 22:34
@younesschrifi younesschrifi force-pushed the yci/delete_scenario_when_deleting_an_infra branch from 37c4685 to b46562a Compare August 20, 2023 22:38
@younesschrifi younesschrifi added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit cab73a6 Aug 22, 2023
3 checks passed
@younesschrifi younesschrifi deleted the yci/delete_scenario_when_deleting_an_infra branch August 22, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DELETE /infra/{id}/ does not work
2 participants
@younesschrifi @leovalais