editoast: faster import #4828
Merged
editoast: faster import #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
force-pushed
the
async_pg
branch
6 times, most recently
from
6408932
to
6c0e58c
Compare
Tristramg
force-pushed
the
faster_import
branch
from
ea7efbc
to
1a12126
Compare
Codecov Report
@@ Coverage Diff @@
## dev #4828 +/- ##
============================================
- Coverage 22.36% 22.35% -0.01%
Complexity 2276 2276
============================================
Files 863 863
Lines 90282 90282
Branches 2324 2324
============================================
- Hits 20188 20186 -2
- Misses 68817 68819 +2
Partials 1277 1277
Flags with carried forward coverage won't be shown. Click here to find out more.
|
flomonster
approved these changes
Aug 28, 2023
This allows to do some CPU-bound work (like serializing to json) while Postgres is already processing some of the data.
Tristramg
force-pushed
the
faster_import
branch
from
1a12126
to
4bae26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4827
It brings the import time from 30 seconds down to 10 (included the performance gain of #4809)