Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: import opendata: correct data format #4850

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner August 18, 2023 15:18
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #4850 (8d28123) into dev (9e1fa0d) will increase coverage by 0.50%.
Report is 4 commits behind head on dev.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4850      +/-   ##
============================================
+ Coverage     21.35%   21.86%   +0.50%     
  Complexity     2248     2248              
============================================
  Files           876      856      -20     
  Lines         92109    89991    -2118     
  Branches       2304     2284      -20     
============================================
+ Hits          19673    19674       +1     
+ Misses        71155    69056    -2099     
+ Partials       1281     1261      -20     
Flag Coverage Δ
front 9.70% <0.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../ImportTrainSchedule/ImportTrainScheduleConfig.tsx 0.00% <0.00%> (ø)

... and 38 files with indirect coverage changes

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local and the import works well ✔️

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit 983e73b Aug 22, 2023
5 checks passed
@nicolaswurtz nicolaswurtz deleted the nwz/import-opendata-correction branch August 22, 2023 09:03
@nicolaswurtz nicolaswurtz linked an issue Aug 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing train schedules doesn't work
2 participants