Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display nothing when budget equals 0 #4868

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

younesschrifi
Copy link
Contributor

close #3989

@younesschrifi younesschrifi requested review from a team as code owners August 23, 2023 11:03
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4868 (06e7ba0) into dev (cea50f8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4868      +/-   ##
============================================
- Coverage     22.35%   22.35%   -0.01%     
  Complexity     2276     2276              
============================================
  Files           863      863              
  Lines         90282    90286       +4     
  Branches       2324     2324              
============================================
  Hits          20184    20184              
- Misses        68821    68825       +4     
  Partials       1277     1277              
Flag Coverage Δ
editoast 70.73% <ø> (ø)
front 10.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...alStudies/components/Study/AddOrEditStudyModal.tsx 0.00% <0.00%> (ø)
.../applications/operationalStudies/views/Project.tsx 0.00% <0.00%> (ø)
...rc/applications/operationalStudies/views/Study.tsx 0.00% <0.00%> (ø)
...dules/project/components/AddOrEditProjectModal.tsx 0.00% <0.00%> (ø)
front/src/modules/study/components/StudyCard.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@younesschrifi younesschrifi force-pushed the yci/fix-budget branch 3 times, most recently from e03ecdf to db595f8 Compare August 24, 2023 10:25
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review openapi legacy

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's intended to display nothing if no budget or financer then LGTM and good job for the fix of the project who wasn't updating :)

@nicolaswurtz nicolaswurtz merged commit 1e94853 into dev Aug 29, 2023
8 of 9 checks passed
@nicolaswurtz nicolaswurtz deleted the yci/fix-budget branch August 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't display "0" when budget === 0
4 participants