Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: disable elevation on map by default #5014

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Sep 11, 2023

closes #5013

  • set terrain3DExaggeration to 0 by default
  • correct a typo: terrain3DExaggerration -> terrain3DExaggeration

@clarani clarani added the area:front Work on Standard OSRD Interface modules label Sep 11, 2023
@clarani clarani requested a review from a team as a code owner September 11, 2023 09:25
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #5014 (3bab07d) into dev (183d22b) will increase coverage by 0.15%.
Report is 6 commits behind head on dev.
The diff coverage is 26.31%.

@@             Coverage Diff              @@
##                dev    #5014      +/-   ##
============================================
+ Coverage     22.15%   22.30%   +0.15%     
  Complexity     2287     2287              
============================================
  Files           852      847       -5     
  Lines         90454    89847     -607     
  Branches       2341     2336       -5     
============================================
+ Hits          20037    20038       +1     
+ Misses        69128    68525     -603     
+ Partials       1289     1284       -5     
Flag Coverage Δ
front 9.92% <26.31%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
front/src/applications/editor/Map.tsx 0.00% <0.00%> (ø)
...onalStudies/components/ManageTrainSchedule/Map.tsx 0.00% <0.00%> (ø)
...ponents/SimulationResults/SimulationResultsMap.tsx 0.00% <0.00%> (ø)
front/src/applications/referenceMap/Map.tsx 0.00% <0.00%> (ø)
front/src/reducers/map/index.ts 48.83% <40.00%> (ø)
front/src/reducers/index.ts 100.00% <100.00%> (ø)
front/src/reducers/map/selectors.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@clarani clarani changed the title front: disable relief on map by default front: disable elevation on map by default Sep 11, 2023
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem to rename, but it's "exaggeration" with two "g" and one "r" !

Please change this too in selector ;) Thx !

@clarani clarani force-pushed the cni-front-5013-disable-relief-by-default branch from 24def5e to 3bab07d Compare September 11, 2023 10:17
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarani clarani added this pull request to the merge queue Sep 12, 2023
Merged via the queue into dev with commit c0401db Sep 12, 2023
5 checks passed
@clarani clarani deleted the cni-front-5013-disable-relief-by-default branch September 12, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: set relief setting to 0 by default
3 participants