Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: modify stdcm allowances settings to display the trains on get #5120

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Sep 21, 2023

closes #5116

@clarani clarani requested a review from a team as a code owner September 21, 2023 08:54
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #5120 (23f8c11) into dev (ee04bf0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #5120   +/-   ##
=========================================
  Coverage     21.56%   21.56%           
  Complexity     2455     2455           
=========================================
  Files           863      863           
  Lines         91196    91176   -20     
  Branches       2503     2503           
=========================================
  Hits          19664    19664           
+ Misses        70161    70141   -20     
  Partials       1371     1371           
Flag Coverage Δ
front 8.43% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../SimulationResults/SpaceTimeChart/withOSRDData.tsx 0.00% <0.00%> (ø)
.../src/applications/stdcm/views/OSRDStdcmResults.tsx 0.00% <0.00%> (ø)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The squares are here, good job !

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Sep 21, 2023
Merged via the queue into dev with commit fd57aab Sep 21, 2023
5 checks passed
@nicolaswurtz nicolaswurtz deleted the cni-front-5116-bug-stdcm branch September 21, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: aspect signals don't appear on the space-time chart
4 participants