Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: improve selectors #5154

Merged
merged 1 commit into from
Oct 3, 2023
Merged

front: improve selectors #5154

merged 1 commit into from
Oct 3, 2023

Conversation

anisometropie
Copy link
Contributor

No description provided.

@anisometropie anisometropie requested a review from a team as a code owner September 28, 2023 20:06
@anisometropie anisometropie force-pushed the vcs/improve-selectors branch 2 times, most recently from a5d5d13 to 33ab964 Compare September 29, 2023 08:47
@anisometropie anisometropie force-pushed the vcs/improve-selectors branch 2 times, most recently from c534595 to 0e2a644 Compare October 3, 2023 11:19
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #5154 (87b0cb8) into dev (be1aea7) will decrease coverage by 0.03%.
The diff coverage is 37.25%.

@@             Coverage Diff              @@
##                dev    #5154      +/-   ##
============================================
- Coverage     18.61%   18.59%   -0.03%     
  Complexity     2469     2469              
============================================
  Files           861      862       +1     
  Lines        106458   106409      -49     
  Branches       2502     2504       +2     
============================================
- Hits          19818    19787      -31     
+ Misses        85271    85251      -20     
- Partials       1369     1371       +2     
Flag Coverage Δ
front 6.98% <37.25%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/reducers/map/selectors.ts 100.00% <100.00%> (ø)
front/src/reducers/user/index.ts 34.50% <0.00%> (ø)
front/src/utils/selectors.ts 86.66% <33.33%> (-7.46%) ⬇️
front/src/reducers/osrdsimulation/selectors.ts 0.00% <0.00%> (ø)
front/src/reducers/user/selectors.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on carto and operational studies ✔️

@anisometropie anisometropie added this pull request to the merge queue Oct 3, 2023
Merged via the queue into dev with commit c96b533 Oct 3, 2023
4 of 5 checks passed
@anisometropie anisometropie deleted the vcs/improve-selectors branch October 3, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants