Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rs-editor: add base power class field #5201

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

SharglutDev
Copy link
Contributor

close #5175

@SharglutDev SharglutDev requested a review from a team as a code owner October 4, 2023 10:07
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #5201 (546fbd0) into dev (f67d2e8) will increase coverage by 0.14%.
The diff coverage is 22.58%.

❗ Current head 546fbd0 differs from pull request most recent head c423adf. Consider uploading reports for the commit c423adf to get more accurate results

@@             Coverage Diff              @@
##                dev    #5201      +/-   ##
============================================
+ Coverage     18.75%   18.90%   +0.14%     
- Complexity     2320     2469     +149     
============================================
  Files           852      860       +8     
  Lines        103332   104583    +1251     
  Branches       2408     2512     +104     
============================================
+ Hits          19379    19767     +388     
- Misses        82615    83448     +833     
- Partials       1338     1368      +30     
Flag Coverage Δ
front 7.03% <22.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/modules/rollingStock/consts.ts 99.32% <100.00%> (+0.01%) ⬆️
front/src/modules/rollingStock/helpers/utils.ts 0.00% <0.00%> (ø)
...ts/RollingStockSelector/RollingStockCardDetail.tsx 0.00% <0.00%> (ø)
...onents/RollingStockSelector/SearchRollingStock.tsx 17.20% <0.00%> (ø)
...llingStockEditor/RollingStockEditorFormHelpers.tsx 0.00% <0.00%> (ø)

... and 192 files with indirect coverage changes

@SharglutDev SharglutDev force-pushed the pfn/front/rs-editor/add-power-class-field branch from 091d346 to 6d14e30 Compare October 4, 2023 14:20
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local with different values and it works well, LGTM

@kmer2016
Copy link
Contributor

kmer2016 commented Oct 6, 2023

There are some fields in RollingStockParametersValues which is not used in Front

@SharglutDev SharglutDev force-pushed the pfn/front/rs-editor/add-power-class-field branch from 6d14e30 to 53f8e13 Compare October 6, 2023 11:40
@SharglutDev SharglutDev force-pushed the pfn/front/rs-editor/add-power-class-field branch from 53f8e13 to 546fbd0 Compare October 9, 2023 13:29
@SharglutDev SharglutDev force-pushed the pfn/front/rs-editor/add-power-class-field branch from 546fbd0 to c423adf Compare October 10, 2023 16:32
@SharglutDev SharglutDev added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit 0764bcf Oct 10, 2023
2 checks passed
@SharglutDev SharglutDev deleted the pfn/front/rs-editor/add-power-class-field branch October 10, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front : be able to enter the base power class of an RS in "general characteristics"
4 participants