Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: separate chunk path from PathProperties #5241

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Oct 6, 2023

Fixes #5242.

@Erashin Erashin requested a review from a team as a code owner October 6, 2023 09:07
@Erashin Erashin added the area:core Work on Core Service label Oct 6, 2023
@Erashin Erashin linked an issue Oct 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5241 (37df1bf) into dev (0764bcf) will increase coverage by 0.00%.
The diff coverage is 84.84%.

@@            Coverage Diff            @@
##                dev    #5241   +/-   ##
=========================================
  Coverage     18.75%   18.76%           
+ Complexity     2320     2318    -2     
=========================================
  Files           852      852           
  Lines        103348   103361   +13     
  Branches       2408     2408           
=========================================
+ Hits          19384    19395   +11     
- Misses        82626    82628    +2     
  Partials       1338     1338           
Flag Coverage Δ
core 78.99% <84.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...otlin/fr/sncf/osrd/sim_infra/api/PathProperties.kt 100.00% <100.00%> (ø)
...ain/java/fr/sncf/osrd/api/stdcm/STDCMEndpoint.java 67.18% <100.00%> (+0.52%) ⬆️
...f/osrd/standalone_sim/ScheduleMetadataExtractor.kt 93.47% <100.00%> (ø)
...ava/fr/sncf/osrd/standalone_sim/StandaloneSim.java 94.87% <100.00%> (+0.06%) ⬆️
.../src/main/java/fr/sncf/osrd/stdcm/STDCMResult.java 100.00% <ø> (ø)
.../fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.java 98.59% <100.00%> (+0.02%) ⬆️
...main/java/fr/sncf/osrd/stdcm/graph/STDCMUtils.java 90.56% <100.00%> (ø)
...va/fr/sncf/osrd/standalone_sim/SignalProjection.kt 0.00% <0.00%> (ø)
...ava/fr/sncf/osrd/api/SignalProjectionEndpoint.java 0.00% <0.00%> (ø)
...ain/java/fr/sncf/osrd/api/utils/PathPropUtils.java 92.30% <66.66%> (-2.78%) ⬇️
... and 1 more

Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a problem in the commits of this PR ? I feel like i've already reviewed those changes in another PR 🤔

@eckter
Copy link
Contributor

eckter commented Oct 6, 2023

Isn't there a problem in the commits of this PR ? I feel like i've already reviewed those changes in another PR 🤔

Only the last commit matters, the rest just means the branch needs to be rebased

Base automatically changed from stdcm-migration to dev October 6, 2023 15:26
@Erashin Erashin force-pushed the alch/core/separate-chunkPath-from-pathProps branch from 15f6739 to 32e19ba Compare October 9, 2023 08:17
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Erashin Erashin force-pushed the alch/core/separate-chunkPath-from-pathProps branch from 32e19ba to bdf933b Compare October 11, 2023 07:30
@Erashin Erashin force-pushed the alch/core/separate-chunkPath-from-pathProps branch from bdf933b to 37df1bf Compare October 11, 2023 07:31
@Erashin Erashin added this pull request to the merge queue Oct 11, 2023
Merged via the queue into dev with commit 3cbed1c Oct 11, 2023
5 checks passed
@Erashin Erashin deleted the alch/core/separate-chunkPath-from-pathProps branch October 11, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: kt-infra: stdcm: remove chunks from PathProperties
4 participants