Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: switch from Option<NonBlankString> to String for Signs #5279

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Oct 10, 2023

No description provided.

@Khoyo Khoyo requested a review from a team as a code owner October 10, 2023 13:59
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5279 (e2375e0) into dev (eb5d93f) will increase coverage by 0.01%.
Report is 2 commits behind head on dev.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #5279      +/-   ##
============================================
+ Coverage     18.66%   18.68%   +0.01%     
  Complexity     2320     2320              
============================================
  Files           856      856              
  Lines        104009   103926      -83     
  Branches       2410     2410              
============================================
- Hits          19416    19414       -2     
+ Misses        83253    83172      -81     
  Partials       1340     1340              
Flag Coverage Δ
core 78.98% <ø> (ø)
editoast 69.77% <ø> (-0.03%) ⬇️
front 7.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/schema/mod.rs 94.20% <ø> (ø)

... and 6 files with indirect coverage changes

@Khoyo Khoyo enabled auto-merge October 10, 2023 14:08
@Khoyo Khoyo added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit 463f7ed Oct 10, 2023
12 of 13 checks passed
@Khoyo Khoyo deleted the yk/fix-signs-option-non-blank branch October 10, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants