Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: update osrd_schemas (pydantic deprecation warning) #5437

Merged
merged 1 commit into from
Oct 30, 2023
Merged

python: update osrd_schemas (pydantic deprecation warning) #5437

merged 1 commit into from
Oct 30, 2023

Conversation

shenriotpro
Copy link
Contributor

No description provided.

@shenriotpro shenriotpro added kind:enhancement Improvement of existing features area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:integration-tests Work on Integration test, by nature related to different services python Pull requests that update Python code labels Oct 23, 2023
@shenriotpro shenriotpro marked this pull request as ready for review October 23, 2023 15:50
@shenriotpro shenriotpro requested review from eckter and a team as code owners October 23, 2023 15:50
flomonster
flomonster requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to bump the osrd_schemas version in railjson_generator

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #5437 (8904e1b) into dev (a3d8d99) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8904e1b differs from pull request most recent head c955b75. Consider uploading reports for the commit c955b75 to get more accurate results

@@            Coverage Diff            @@
##                dev    #5437   +/-   ##
=========================================
  Coverage     18.79%   18.79%           
  Complexity     2320     2320           
=========================================
  Files           861      861           
  Lines        103573   103573           
  Branches       2412     2412           
=========================================
+ Hits          19464    19466    +2     
+ Misses        82761    82759    -2     
  Partials       1348     1348
Flag Coverage Δ
core 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

flomonster
flomonster approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenriotpro shenriotpro added this pull request to the merge queue Oct 30, 2023
Merged via the queue into dev with commit 96fbe2b Oct 30, 2023
4 checks passed
@shenriotpro shenriotpro deleted the shenriot-deprecated-min branch October 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter approved these changes

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
area:integration-tests Work on Integration test, by nature related to different services area:railjson Work on Proposed Unified Rail Assets Data Exchange Format kind:enhancement Improvement of existing features python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shenriotpro @eckter @flomonster