Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix infinite loop caused by warped map #5462

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

SharglutDev
Copy link
Contributor

close #5444

@SharglutDev SharglutDev requested a review from a team as a code owner October 25, 2023 14:46
@SharglutDev
Copy link
Contributor Author

This fix does the job but not sure why it worked for the past weeks since the warped map was introduced.

Seems that it started with the 20th October dump ?

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5462 (9441d45) into dev (4dc1044) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5462      +/-   ##
============================================
- Coverage     18.83%   18.83%   -0.01%     
  Complexity     2317     2317              
============================================
  Files           859      859              
  Lines        103429   103435       +6     
  Branches       2410     2410              
============================================
  Hits          19480    19480              
- Misses        82601    82607       +6     
  Partials       1348     1348              
Flag Coverage Δ
front 7.15% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t/src/common/Map/WarpedMap/SimulationWarpedMap.tsx 0.00% <0.00%> (ø)
front/src/reducers/osrdconf/index.ts 33.14% <0.00%> (-0.24%) ⬇️

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks for the comments

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✔️

@SharglutDev SharglutDev added this pull request to the merge queue Oct 26, 2023
Merged via the queue into dev with commit 50ba6a7 Oct 26, 2023
4 of 5 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-multiple-infra-call branch October 26, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple infra api calls
3 participants