Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front/editor-form: fix undefined values in formdata #5507

Merged
merged 3 commits into from
Nov 2, 2023
Merged

front/editor-form: fix undefined values in formdata #5507

merged 3 commits into from
Nov 2, 2023

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Oct 27, 2023 •
edited by clarani
Loading

closes #5480
closes #5487
closes #5556

@SarahBellaha SarahBellaha requested a review from a team as a code owner October 27, 2023 12:47
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #5507 (f15ba70) into dev (aa9ff62) will decrease coverage by 0.02%.
Report is 3 commits behind head on dev.
The diff coverage is 2.50%.

@@             Coverage Diff              @@
##                dev    #5507      +/-   ##
============================================
- Coverage     19.49%   19.48%   -0.02%     
  Complexity     2322     2322              
============================================
  Files           878      878              
  Lines        105423   105486      +63     
  Branches       2544     2544              
============================================
  Hits          20555    20555              
- Misses        83387    83450      +63     
  Partials       1481     1481
Flag Coverage Δ
front 8.21% <2.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/applications/editor/data/utils.ts 35.41% <75.00%> (ø)
.../src/applications/editor/components/EditorForm.tsx 0.00% <0.00%> (ø)
front/src/types/editor.ts 0.00% <0.00%> (ø)
...lications/editor/tools/pointEdition/components.tsx 0.00% <0.00%> (ø)
...rc/applications/editor/tools/pointEdition/utils.ts 0.00% <0.00%> (ø)

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-undefined-fields-in-formData branch 2 times, most recently from 4c728f6 to c5fdf08 Compare October 30, 2023 14:31
@SarahBellaha SarahBellaha linked an issue Oct 30, 2023 that may be closed by this pull request
front: editor: can not save a created signal once it has been saved #5487
Closed
@SarahBellaha SarahBellaha force-pushed the sba/front/fix-undefined-fields-in-formData branch 2 times, most recently from 968daae to 336a49b Compare October 30, 2023 16:21
@SarahBellaha SarahBellaha force-pushed the sba/front/fix-undefined-fields-in-formData branch from 336a49b to f15ba70 Compare November 2, 2023 10:56
clarani
clarani approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local ✅

@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit c2b9acd Nov 2, 2023
4 of 5 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-undefined-fields-in-formData branch November 2, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandredamiron alexandredamiron alexandredamiron approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@SarahBellaha @alexandredamiron @clarani