Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: disable unit selector in rolling stock editor form #5604

Merged
merged 1 commit into from
Nov 8, 2023
Merged

front: disable unit selector in rolling stock editor form #5604

merged 1 commit into from
Nov 8, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 6, 2023

closes #5559

@clarani clarani requested a review from a team as a code owner November 6, 2023 06:57
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #5604 (17a3991) into dev (49d621d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5604      +/-   ##
============================================
- Coverage     19.48%   19.48%   -0.01%     
  Complexity     2322     2322              
============================================
  Files           878      878              
  Lines        105491   105495       +4     
  Branches       2544     2544              
============================================
  Hits          20560    20560              
- Misses        83450    83454       +4     
  Partials       1481     1481
Flag Coverage Δ
front 8.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...llingStockEditor/RollingStockEditorFormHelpers.tsx 0.00% <0.00%> (ø)
front/src/common/BootstrapSNCF/InputGroupSNCF.tsx 0.00% <0.00%> (ø)

Yohh
Yohh approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Akctarus
Akctarus approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Math-R
Copy link
Contributor

Math-R commented Nov 8, 2023

lgtm

@clarani clarani added this pull request to the merge queue Nov 8, 2023
Merged via the queue into dev with commit 5c88cf6 Nov 8, 2023
4 of 5 checks passed
@clarani clarani deleted the cni-5559-disable-unit-selector-in-rs-editor branch November 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadjetz Wadjetz Wadjetz approved these changes

@Yohh Yohh Yohh approved these changes

@Math-R Math-R Math-R approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit selector in rolling stock editor should be disabled
5 participants
@clarani @Math-R @Wadjetz @Yohh @Akctarus