front: fix icons in editor, reference map, stdcm #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarani
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Thanks for this PR, great job !!
Here are some additional specifications:
- use the icons Thibaut chose (sorry, I forgot to write them in the ticket, my bad 😞 )
- layers : BsSliders2
- compass (boussole) : FaRegCompass
- remove the button to recenter the map in the editor
- reorder the buttons so they are in the same order:
- zoom-in/zoom-out
- compass
- search (only for reference map)
- layers
- infra
- error (only for editor) / legend (only for reference map)
- remove the space between icons in editor (between compass and layers)
...dules/trainschedule/components/ManageTrainSchedule/Allowances/AllowancesStandardSettings.tsx
Outdated
Show resolved
Hide resolved
RomainValls
force-pushed
the
rvs/front-fix-icons-in-editor-and-reference-map
branch
from
e152f99
to
98318f3
Compare
clarani
reviewed
Dec 1, 2023
There was a problem hiding this comment.
2 last small things:
- the infra button should be above the legend one on the reference map (current app here:)
- the pop up text for the infra selector button is "choose infra to edit" even in the reference map, but it should be "choose infrastructure" simply. Can you add a new translation key for that ?
RomainValls
force-pushed
the
rvs/front-fix-icons-in-editor-and-reference-map
branch
2 times, most recently
from
05311e6
to
240275f
Compare
- re work icons, remove dead code, add translation key - add translation key and modify button order - Update front/src/applications/editor/Editor.tsx Co-authored-by: clarani <clara.ni@student-cs.fr>
RomainValls
force-pushed
the
rvs/front-fix-icons-in-editor-and-reference-map
branch
from
240275f
to
b15bf5d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5669 +/- ##
============================================
+ Coverage 25.80% 25.85% +0.05%
Complexity 2117 2117
============================================
Files 926 928 +2
Lines 122492 122691 +199
Branches 2665 2667 +2
============================================
+ Hits 31605 31722 +117
- Misses 89314 89394 +80
- Partials 1573 1575 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
approved these changes
Dec 5, 2023
RomainValls
deleted the
rvs/front-fix-icons-in-editor-and-reference-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5524