Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor: fix route tool selection #5692

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

SarahBellaha
Copy link
Contributor

Closes #5598
Closes #5599

@SarahBellaha SarahBellaha added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:infra-editor Infra Edition labels Nov 15, 2023
@SarahBellaha SarahBellaha requested a review from a team as a code owner November 15, 2023 11:25
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (8d55deb) 19.59% compared to head (511ed79) 19.59%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...or/tools/routeEdition/components/WayPointInput.tsx 0.00% 17 Missing ⚠️
...editor/tools/routeEdition/components/Endpoints.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5692   +/-   ##
=========================================
  Coverage     19.59%   19.59%           
  Complexity     2323     2323           
=========================================
  Files           886      886           
  Lines        105824   105823    -1     
  Branches       2572     2572           
=========================================
  Hits          20740    20740           
+ Misses        83576    83575    -1     
  Partials       1508     1508           
Flag Coverage Δ
front 8.30% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51
Copy link
Contributor

sim51 commented Nov 15, 2023

@SarahBellaha I can click on both buttons, and at the end I don't know which one is selected :

image

The click on one button should disable the other one.

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-route-tool-selection branch 2 times, most recently from 2aa21e2 to c7026b0 Compare November 15, 2023 15:05
@clarani
Copy link
Contributor

clarani commented Nov 15, 2023

Tested, very nice job !

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-route-tool-selection branch from c7026b0 to 511ed79 Compare November 15, 2023 16:30
@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 15, 2023
Merged via the queue into dev with commit 364e305 Nov 15, 2023
5 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-route-tool-selection branch November 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition
Projects
None yet
4 participants