Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: platform layer is enabled only when OSM is #5757

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 20, 2023

Close #5594

@sim51 sim51 requested a review from a team as a code owner November 20, 2023 14:56
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (61a0ebd) 19.45% compared to head (fc53957) 19.52%.
Report is 11 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/Platforms.tsx 0.00% 9 Missing ⚠️
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% 7 Missing ⚠️
...src/applications/editor/components/LayersModal.tsx 0.00% 5 Missing ⚠️
...ront/src/common/Map/Settings/MapSettingsLayers.tsx 0.00% 4 Missing ⚠️
front/src/applications/editor/Map.tsx 0.00% 3 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 2 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 2 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 2 Missing ⚠️
...lications/editor/tools/routeEdition/components.tsx 0.00% 1 Missing ⚠️
front/src/applications/editor/tools/types.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5757      +/-   ##
============================================
+ Coverage     19.45%   19.52%   +0.06%     
  Complexity     2327     2327              
============================================
  Files           907      907              
  Lines        106925   106989      +64     
  Branches       2579     2590      +11     
============================================
+ Hits          20801    20885      +84     
+ Misses        84609    84578      -31     
- Partials       1515     1526      +11     
Flag Coverage Δ
front 8.41% <5.12%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 force-pushed the bsi/issue-5594 branch 2 times, most recently from faef42b to f47b1cc Compare November 21, 2023 14:56
@sim51 sim51 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 8eb066c Nov 22, 2023
7 checks passed
@sim51 sim51 deleted the bsi/issue-5594 branch November 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: edition: when turning map layers off, there are still things showing up
2 participants