Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stdcm origin time panel behaviour #5761

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 20, 2023

closes #4419

@clarani clarani requested a review from a team as a code owner November 20, 2023 16:55
@clarani clarani force-pushed the cni-4419-fix-stdcm-origin-window branch from e5aa89f to 3785b84 Compare November 22, 2023 16:28
front/src/reducers/osrdconf/helpers.ts Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni-4419-fix-stdcm-origin-window branch from 3785b84 to 9a1987e Compare November 23, 2023 11:26
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (2b6e7d0) 19.45% compared to head (9a1987e) 19.63%.
Report is 55 commits behind head on dev.

Files Patch % Lines
front/src/reducers/osrdconf/helpers.ts 80.55% 0 Missing and 14 partials ⚠️
front/src/reducers/osrdconf/index.ts 74.35% 4 Missing and 6 partials ⚠️
front/src/reducers/osrdconf2/common/index.ts 72.22% 4 Missing and 6 partials ⚠️
...rainSchedule/Itinerary/DisplayItinerary/Origin.tsx 0.00% 8 Missing ⚠️
...t/src/applications/stdcm/views/OSRDStdcmConfig.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5761      +/-   ##
============================================
+ Coverage     19.45%   19.63%   +0.18%     
  Complexity     2327     2327              
============================================
  Files           907      908       +1     
  Lines        106928   107713     +785     
  Branches       2579     2623      +44     
============================================
+ Hits          20801    21149     +348     
- Misses        84612    85005     +393     
- Partials       1515     1559      +44     
Flag Coverage Δ
front 8.64% <71.51%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! nicely done :)

@clarani clarani added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 9da5c42 Nov 23, 2023
7 checks passed
@clarani clarani deleted the cni-4419-fix-stdcm-origin-window branch November 23, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM departure time window is acting very strange
2 participants