Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix psl position input to handle 0 #5781

Merged
merged 2 commits into from
Nov 22, 2023
Merged

front: fix psl position input to handle 0 #5781

merged 2 commits into from
Nov 22, 2023

Conversation

Akctarus
Copy link
Contributor

closes #4495

@Akctarus Akctarus requested a review from a team as a code owner November 21, 2023 16:18
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4e8db62) 19.52% compared to head (c92901a) 19.48%.
Report is 29 commits behind head on dev.

Files Patch % Lines
...or/tools/rangeEdition/speedSection/PslSignCard.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5781      +/-   ##
============================================
- Coverage     19.52%   19.48%   -0.04%     
  Complexity     2327     2327              
============================================
  Files           907      907              
  Lines        106974   107066      +92     
  Branches       2590     2587       -3     
============================================
- Hits          20883    20867      -16     
- Misses        84565    84676     +111     
+ Partials       1526     1523       -3
Flag Coverage Δ
front 8.38% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus changed the title front: fix lpv position input to handle 0 front: fix psl position input to handle 0 Nov 21, 2023
clarani
clarani reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I enter 0, nothing is displayed

nicolaswurtz
nicolaswurtz previously approved these changes Nov 22, 2023
View reviewed changes
@nicolaswurtz nicolaswurtz self-requested a review November 22, 2023 13:16
@nicolaswurtz nicolaswurtz dismissed their stale review November 22, 2023 13:17

Sorry, too fast click !

clarani
clarani approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@Akctarus Akctarus added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 9a11e19 Nov 22, 2023
6 of 7 checks passed
@Akctarus Akctarus deleted the tmn/handle-0-in-psl-input branch November 22, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@nicolaswurtz nicolaswurtz Awaiting requested review from nicolaswurtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor : 0 value isn't correctly handled for the LPVs panels position
3 participants
@Akctarus @nicolaswurtz @clarani