Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: migrate stdcm and pathfinding modules to kotlin #5785

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 22, 2023

To do:

  • Automatically convert java to kotlin
  • Fix types in places where proper typing was missing (e.g. Int -> BlockId)
  • Fix any leftover compiling error
  • Fix any failed test
  • Double check for java function that haven't been replaced (e.g. List.of)
  • Double check typing (Distance / Length / Offset) edit: will be a different PR
  • Run code formater
  • Remove unnecessary @JVMName
  • Fix conflicts with main branch

@eckter eckter linked an issue Nov 22, 2023 that may be closed by this pull request
7 tasks
@eckter eckter force-pushed the migrate-stdcm-kt branch 3 times, most recently from 0eeff8e to d05f3b0 Compare November 22, 2023 11:31
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (113da3b) 19.85%.

Files Patch % Lines
.../osrd/api/pathfinding/PathfindingBlocksEndpoint.kt 87.08% 15 Missing and 12 partials ⚠️
...fr/sncf/osrd/stdcm/graph/STDCMStandardAllowance.kt 74.60% 8 Missing and 8 partials ⚠️
...rocessing/interfaces/BlockAvailabilityInterface.kt 38.46% 12 Missing and 4 partials ⚠️
...osrd/api/pathfinding/PathfindingResultConverter.kt 92.96% 4 Missing and 10 partials ⚠️
...srd/api/pathfinding/response/PathWaypointResult.kt 59.37% 5 Missing and 8 partials ⚠️
...ain/kotlin/fr/sncf/osrd/api/stdcm/STDCMEndpoint.kt 86.07% 6 Missing and 5 partials ⚠️
...otlin/fr/sncf/osrd/stdcm/graph/AllowanceManager.kt 90.36% 3 Missing and 5 partials ⚠️
...otlin/fr/sncf/osrd/stdcm/graph/STDCMEdgeBuilder.kt 92.66% 3 Missing and 5 partials ⚠️
.../main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMEdge.kt 85.41% 3 Missing and 4 partials ⚠️
.../api/pathfinding/response/CurveChartPointResult.kt 25.00% 3 Missing and 3 partials ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5785      +/-   ##
============================================
+ Coverage     19.70%   19.85%   +0.15%     
+ Complexity     2345     2122     -223     
============================================
  Files           910      910              
  Lines        108075   108294     +219     
  Branches       2634     2649      +15     
============================================
+ Hits          21299    21505     +206     
- Misses        85216    85235      +19     
+ Partials       1560     1554       -6     
Flag Coverage Δ
core 79.10% <90.92%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the migrate-stdcm-kt branch 5 times, most recently from b7d69de to 91292d3 Compare November 22, 2023 15:18
@eckter eckter marked this pull request as ready for review November 22, 2023 15:26
@eckter eckter requested a review from a team as a code owner November 22, 2023 15:26
@eckter eckter requested a review from multun November 22, 2023 15:26
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes can be treated in another pr, let me know.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@eckter eckter added this pull request to the merge queue Nov 27, 2023
Merged via the queue into dev with commit f5848dd Nov 27, 2023
7 checks passed
@eckter eckter deleted the migrate-stdcm-kt branch November 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: migrate stdcm and pathfinding to kotlin
3 participants